From 00251f11b1dd871981f01b101d7cec34920d7cfe Mon Sep 17 00:00:00 2001
From: IrynaMatveieva <irina.m2004@icloud.com>
Date: Wed, 29 May 2024 11:19:15 +0300
Subject: [PATCH] refactored tests

---
 .../TbSaveToCustomCassandraTableNodeTest.java | 22 +++++++------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/action/TbSaveToCustomCassandraTableNodeTest.java b/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/action/TbSaveToCustomCassandraTableNodeTest.java
index 699af15fa3..d760568bd4 100644
--- a/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/action/TbSaveToCustomCassandraTableNodeTest.java
+++ b/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/action/TbSaveToCustomCassandraTableNodeTest.java
@@ -25,6 +25,7 @@ import com.datastax.oss.driver.api.core.metadata.Node;
 import com.datastax.oss.driver.api.core.type.codec.registry.CodecRegistry;
 
 import com.google.common.util.concurrent.SettableFuture;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
@@ -95,10 +96,14 @@ public class TbSaveToCustomCassandraTableNodeTest {
     @Mock
     private Node nodeMock;
 
+    @BeforeEach
+    void setUp() {
+        node = spy(new TbSaveToCustomCassandraTableNode());
+        config = new TbSaveToCustomCassandraTableNodeConfiguration().defaultConfiguration();
+    }
+
     @Test
     void givenCassandraClusterIsMissing_whenInit_thenThrowsException() {
-        node = new TbSaveToCustomCassandraTableNode();
-        config = new TbSaveToCustomCassandraTableNodeConfiguration().defaultConfiguration();
         var configuration = new TbNodeConfiguration(JacksonUtil.valueToTree(config));
         assertThatThrownBy(() -> node.init(ctxMock, configuration))
                 .isInstanceOf(RuntimeException.class)
@@ -107,8 +112,6 @@ public class TbSaveToCustomCassandraTableNodeTest {
 
     @Test
     void givenFieldsMapIsEmpty_whenInit_thenThrowsException() {
-        node = new TbSaveToCustomCassandraTableNode();
-        config = new TbSaveToCustomCassandraTableNodeConfiguration().defaultConfiguration();
         config.setFieldsMapping(emptyMap());
         var configuration = new TbNodeConfiguration(JacksonUtil.valueToTree(config));
 
@@ -121,8 +124,6 @@ public class TbSaveToCustomCassandraTableNodeTest {
 
     @Test
     void givenInvalidMessageStructure_whenOnMsg_thenThrowsException() throws TbNodeException {
-        node = new TbSaveToCustomCassandraTableNode();
-        config = new TbSaveToCustomCassandraTableNodeConfiguration().defaultConfiguration();
         config.setTableName("temperature_sensor");
         config.setFieldsMapping(Map.of("temp", "temperature"));
         var configuration = new TbNodeConfiguration(JacksonUtil.valueToTree(config));
@@ -131,8 +132,7 @@ public class TbSaveToCustomCassandraTableNodeTest {
 
         node.init(ctxMock, configuration);
 
-        String data = "";
-        TbMsg msg = TbMsg.newMsg(TbMsgType.POST_TELEMETRY_REQUEST, DEVICE_ID, TbMsgMetaData.EMPTY, data);
+        TbMsg msg = TbMsg.newMsg(TbMsgType.POST_TELEMETRY_REQUEST, DEVICE_ID, TbMsgMetaData.EMPTY, TbMsg.EMPTY_STRING);
 
         assertThatThrownBy(() -> node.onMsg(ctxMock, msg))
                 .isInstanceOf(IllegalStateException.class)
@@ -141,8 +141,6 @@ public class TbSaveToCustomCassandraTableNodeTest {
 
     @Test
     void givenDataKeyIsMissingInMsg_whenOnMsg_thenThrowsException() throws TbNodeException {
-        node = new TbSaveToCustomCassandraTableNode();
-        config = new TbSaveToCustomCassandraTableNodeConfiguration().defaultConfiguration();
         config.setTableName("temperature_sensor");
         config.setFieldsMapping(Map.of("temp", "temperature"));
         var configuration = new TbNodeConfiguration(JacksonUtil.valueToTree(config));
@@ -171,8 +169,6 @@ public class TbSaveToCustomCassandraTableNodeTest {
 
     @Test
     void givenUnsupportedData_whenOnMsg_thenThrowsException() throws TbNodeException {
-        node = new TbSaveToCustomCassandraTableNode();
-        config = new TbSaveToCustomCassandraTableNodeConfiguration().defaultConfiguration();
         config.setTableName("temperature_sensor");
         config.setFieldsMapping(Map.of("temp", "temperature"));
         var configuration = new TbNodeConfiguration(JacksonUtil.valueToTree(config));
@@ -203,8 +199,6 @@ public class TbSaveToCustomCassandraTableNodeTest {
 
     @Test
     void givenValidMsgStructure_whenOnMsg_thenOk() throws Exception {
-        node = spy(new TbSaveToCustomCassandraTableNode());
-        config = new TbSaveToCustomCassandraTableNodeConfiguration().defaultConfiguration();
         config.setTableName("temperature_sensor");
         config.setFieldsMapping(Map.of("temp", "temperature"));
         var configuration = new TbNodeConfiguration(JacksonUtil.valueToTree(config));