From 050fa670af450c89ad6e84372004d558c6c85ffb Mon Sep 17 00:00:00 2001
From: deaflynx <artemio.babak@gmail.com>
Date: Fri, 6 Jun 2025 17:37:51 +0300
Subject: [PATCH] UI: Minor improvement of excludeVersions in mqtt version
 select.

---
 .../mqtt-version-select.component.ts          | 23 ++++++++++++++-----
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/ui-ngx/src/app/shared/components/mqtt-version-select.component.ts b/ui-ngx/src/app/shared/components/mqtt-version-select.component.ts
index 5145a7fd51..0a9b75be2d 100644
--- a/ui-ngx/src/app/shared/components/mqtt-version-select.component.ts
+++ b/ui-ngx/src/app/shared/components/mqtt-version-select.component.ts
@@ -14,7 +14,7 @@
 /// limitations under the License.
 ///
 
-import { Component, forwardRef, Input } from '@angular/core';
+import { Component, forwardRef, Input, OnChanges, SimpleChanges } from '@angular/core';
 import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';
 import { coerceBoolean } from '@shared/decorators/coercion';
 import { SubscriptSizing, MatFormFieldAppearance } from '@angular/material/form-field';
@@ -30,7 +30,7 @@ import { MqttVersionTranslation, MqttVersion } from '@shared/models/mqtt.models'
     multi: true
   }]
 })
-export class MqttVersionSelectComponent implements ControlValueAccessor {
+export class MqttVersionSelectComponent implements ControlValueAccessor, OnChanges {
 
   @Input()
   disabled: boolean;
@@ -44,10 +44,7 @@ export class MqttVersionSelectComponent implements ControlValueAccessor {
   @Input()
   excludeVersions: MqttVersion[];
 
-  get mqttVersions(): MqttVersion[] {
-    return Object.values(MqttVersion).filter(v => !this.excludeVersions || !this.excludeVersions.includes(v));
-  }
-
+  mqttVersions =  Object.values(MqttVersion);
   mqttVersionTranslation = MqttVersionTranslation;
   modelValue: MqttVersion;
 
@@ -60,6 +57,20 @@ export class MqttVersionSelectComponent implements ControlValueAccessor {
   constructor() {
   }
 
+  ngOnChanges(changes: SimpleChanges): void {
+    for (const propName of Object.keys(changes)) {
+      const change = changes[propName];
+      if (propName === 'excludeVersions' && change.currentValue !== change.previousValue) {
+        const excludeVersions = change.currentValue;
+        if (excludeVersions?.length) {
+          this.mqttVersions = Object.values(MqttVersion).filter(v => !excludeVersions.includes(v));
+        } else {
+          this.mqttVersions = Object.values(MqttVersion);
+        }
+      }
+    }
+  }
+
   registerOnChange(fn: any): void {
     this.propagateChange = fn;
   }