diff --git a/dao/src/main/java/org/thingsboard/server/dao/asset/AssetProfileServiceImpl.java b/dao/src/main/java/org/thingsboard/server/dao/asset/AssetProfileServiceImpl.java index 95786f0a6a..7d4d5300f9 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/asset/AssetProfileServiceImpl.java +++ b/dao/src/main/java/org/thingsboard/server/dao/asset/AssetProfileServiceImpl.java @@ -236,8 +236,9 @@ public class AssetProfileServiceImpl extends CachedVersionedEntityService INCORRECT_TENANT_ID + id); AssetProfile assetProfile = new AssetProfile(); assetProfile.setTenantId(tenantId); diff --git a/dao/src/main/java/org/thingsboard/server/dao/device/DeviceProfileServiceImpl.java b/dao/src/main/java/org/thingsboard/server/dao/device/DeviceProfileServiceImpl.java index 1528763775..09e2be01e0 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/device/DeviceProfileServiceImpl.java +++ b/dao/src/main/java/org/thingsboard/server/dao/device/DeviceProfileServiceImpl.java @@ -271,8 +271,9 @@ public class DeviceProfileServiceImpl extends CachedVersionedEntityService INCORRECT_TENANT_ID + id); DeviceProfile deviceProfile = new DeviceProfile(); deviceProfile.setTenantId(tenantId); diff --git a/dao/src/test/java/org/thingsboard/server/dao/service/AssetProfileServiceTest.java b/dao/src/test/java/org/thingsboard/server/dao/service/AssetProfileServiceTest.java index d7b17fe53a..7271a0fc8a 100644 --- a/dao/src/test/java/org/thingsboard/server/dao/service/AssetProfileServiceTest.java +++ b/dao/src/test/java/org/thingsboard/server/dao/service/AssetProfileServiceTest.java @@ -163,6 +163,18 @@ public class AssetProfileServiceTest extends AbstractServiceTest { }); } + @Test + public void testSaveAssetProfileWithNameDefaultAndProfileWithIsDefaultAndDifferentNameAlreadyExists() { + AssetProfile defaultAssetProfile = assetProfileService.findDefaultAssetProfile(tenantId); + Assert.assertNotNull(defaultAssetProfile); + defaultAssetProfile.setName("Asset Profile 1"); + assetProfileService.saveAssetProfile(defaultAssetProfile); + AssetProfile createdAssetProfile = assetProfileService.findOrCreateAssetProfile(tenantId, "default"); + Assert.assertNotNull(createdAssetProfile); + Assert.assertEquals("default", createdAssetProfile.getName()); + Assert.assertFalse(createdAssetProfile.isDefault()); + } + @Test public void testDeleteAssetProfileWithExistingAsset() { AssetProfile assetProfile = this.createAssetProfile(tenantId, "Asset Profile"); diff --git a/dao/src/test/java/org/thingsboard/server/dao/service/DeviceProfileServiceTest.java b/dao/src/test/java/org/thingsboard/server/dao/service/DeviceProfileServiceTest.java index 51abe245b2..aa14e20151 100644 --- a/dao/src/test/java/org/thingsboard/server/dao/service/DeviceProfileServiceTest.java +++ b/dao/src/test/java/org/thingsboard/server/dao/service/DeviceProfileServiceTest.java @@ -209,6 +209,18 @@ public class DeviceProfileServiceTest extends AbstractServiceTest { }); } + @Test + public void testSaveDeviceProfileWithNameDefaultAndProfileWithIsDefaultAndDifferentNameAlreadyExists() { + DeviceProfile defaultDeviceProfile = deviceProfileService.findDefaultDeviceProfile(tenantId); + Assert.assertNotNull(defaultDeviceProfile); + defaultDeviceProfile.setName("Device Profile 1"); + deviceProfileService.saveDeviceProfile(defaultDeviceProfile); + DeviceProfile createdDeviceProfile = deviceProfileService.findOrCreateDeviceProfile(tenantId, "default"); + Assert.assertNotNull(createdDeviceProfile); + Assert.assertEquals("default", createdDeviceProfile.getName()); + Assert.assertFalse(createdDeviceProfile.isDefault()); + } + @Ignore @Test public void testChangeDeviceProfileTypeWithExistingDevices() {