From 1aaa017d92b91401a702c4626f9bc3c0ef07d92a Mon Sep 17 00:00:00 2001 From: ViacheslavKlimov Date: Thu, 7 Sep 2023 13:28:32 +0300 Subject: [PATCH] Add ports configs for SNMP transport to Docker scripts --- .../server/transport/snmp/service/SnmpTransportService.java | 4 ++-- docker/docker-compose.yml | 2 ++ docker/tb-snmp-transport.env | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/common/transport/snmp/src/main/java/org/thingsboard/server/transport/snmp/service/SnmpTransportService.java b/common/transport/snmp/src/main/java/org/thingsboard/server/transport/snmp/service/SnmpTransportService.java index 38e3077ebb..0b60db68b1 100644 --- a/common/transport/snmp/src/main/java/org/thingsboard/server/transport/snmp/service/SnmpTransportService.java +++ b/common/transport/snmp/src/main/java/org/thingsboard/server/transport/snmp/service/SnmpTransportService.java @@ -302,8 +302,8 @@ public class SnmpTransportService implements TbTransportService, CommandResponde * * TODO: add check for host uniqueness when saving device (for backward compatibility - only for the ones using from-device RPC requests) * - * TODO: this won't work properly in a cluster mode, due to load-balancing of requests from devices: - * session might not be on this instance + * NOTE: SNMP TRAPs support won't work properly when there is more than one SNMP transport, + * due to load-balancing of requests from devices: session might not be on this instance * */ @Override public void processPdu(CommandResponderEvent event) { diff --git a/docker/docker-compose.yml b/docker/docker-compose.yml index b4320577c7..78ca337e0a 100644 --- a/docker/docker-compose.yml +++ b/docker/docker-compose.yml @@ -235,6 +235,8 @@ services: tb-snmp-transport: restart: always image: "${DOCKER_REPO}/${SNMP_TRANSPORT_DOCKER_NAME}:${TB_VERSION}" + ports: + - "1620:1620/udp" environment: TB_SERVICE_ID: tb-snmp-transport JAVA_OPTS: "${JAVA_OPTS}" diff --git a/docker/tb-snmp-transport.env b/docker/tb-snmp-transport.env index e2cc39d658..32160de100 100644 --- a/docker/tb-snmp-transport.env +++ b/docker/tb-snmp-transport.env @@ -1,6 +1,7 @@ ZOOKEEPER_ENABLED=true ZOOKEEPER_URL=zookeeper:2181 +SNMP_BIND_PORT=1620 METRICS_ENABLED=true METRICS_ENDPOINTS_EXPOSE=prometheus WEB_APPLICATION_ENABLE=true