Optimized imports

common/transport/coap/src/main/java/org/thingsboard/server/transport/coap/AbstractCoapTransportResource.java

@@ -15,29 +15,13 @@
  */
 package org.thingsboard.server.transport.coap;
 
-import lombok.SneakyThrows;
 import lombok.extern.slf4j.Slf4j;
 import org.eclipse.californium.core.CoapResource;
-import org.eclipse.californium.core.coap.CoAP;
-import org.eclipse.californium.core.coap.MessageObserver;
-import org.eclipse.californium.core.coap.Response;
 import org.eclipse.californium.core.server.resources.CoapExchange;
-import org.eclipse.californium.elements.EndpointContext;
-import org.thingsboard.server.common.data.DeviceProfile;
-import org.thingsboard.server.common.transport.TransportContext;
 import org.thingsboard.server.common.transport.TransportService;
 import org.thingsboard.server.common.transport.TransportServiceCallback;
-import org.thingsboard.server.common.transport.auth.SessionInfoCreator;
-import org.thingsboard.server.common.transport.auth.ValidateDeviceCredentialsResponse;
 import org.thingsboard.server.gen.transport.TransportProtos;
 
-import java.util.UUID;
-import java.util.concurrent.ThreadLocalRandom;
-import java.util.function.BiConsumer;
-
-import static org.eclipse.californium.core.coap.Message.MAX_MID;
-import static org.eclipse.californium.core.coap.Message.NONE;
-
 @Slf4j
 public abstract class AbstractCoapTransportResource extends CoapResource {
 

common/transport/coap/src/main/java/org/thingsboard/server/transport/coap/adaptors/JsonCoapAdaptor.java

@@ -33,7 +33,6 @@ import org.thingsboard.server.common.transport.adaptor.JsonConverter;
 import org.thingsboard.server.gen.transport.TransportProtos;
 import org.thingsboard.server.transport.coap.CoapTransportResource;
 
-import java.util.List;
 import java.util.Optional;
 import java.util.UUID;
 

common/transport/coap/src/main/java/org/thingsboard/server/transport/coap/callback/CoapDeviceAuthCallback.java

@@ -19,14 +19,9 @@ import lombok.extern.slf4j.Slf4j;
 import org.eclipse.californium.core.coap.CoAP;
 import org.eclipse.californium.core.server.resources.CoapExchange;
 import org.thingsboard.server.common.data.DeviceProfile;
-import org.thingsboard.server.common.transport.TransportContext;
 import org.thingsboard.server.common.transport.TransportServiceCallback;
-import org.thingsboard.server.common.transport.auth.SessionInfoCreator;
 import org.thingsboard.server.common.transport.auth.ValidateDeviceCredentialsResponse;
-import org.thingsboard.server.gen.transport.TransportProtos;
-import org.thingsboard.server.transport.coap.AbstractCoapTransportResource;
 
-import java.util.UUID;
 import java.util.function.BiConsumer;
 
 @Slf4j

common/transport/coap/src/main/java/org/thingsboard/server/transport/coap/callback/GetAttributesSyncSessionCallback.java

@@ -23,7 +23,6 @@ import org.eclipse.californium.core.server.resources.CoapExchange;
 import org.thingsboard.server.common.transport.adaptor.AdaptorException;
 import org.thingsboard.server.gen.transport.TransportProtos;
 import org.thingsboard.server.transport.coap.client.TbCoapClientState;
-import org.thingsboard.server.transport.coap.client.TbCoapObservationState;
 
 @Slf4j
 public class GetAttributesSyncSessionCallback extends AbstractSyncSessionCallback {

common/transport/coap/src/main/java/org/thingsboard/server/transport/coap/callback/ToServerRpcSyncSessionCallback.java

@@ -23,8 +23,6 @@ import org.thingsboard.server.common.transport.adaptor.AdaptorException;
 import org.thingsboard.server.gen.transport.TransportProtos;
 import org.thingsboard.server.transport.coap.client.TbCoapClientState;
 
-import java.util.UUID;
-
 @Slf4j
 public class ToServerRpcSyncSessionCallback extends AbstractSyncSessionCallback {
 

common/transport/coap/src/main/java/org/thingsboard/server/transport/coap/client/CoapClientContext.java

@@ -31,8 +31,6 @@ public interface CoapClientContext {
 
     boolean registerRpcObservation(TbCoapClientState clientState, String token, CoapExchange exchange);
 
-    void onUplink(TransportProtos.SessionInfoProto sessionInfo);
-
     AtomicInteger getNotificationCounterByToken(String token);
 
     TbCoapClientState getOrCreateClient(SessionMsgType type, ValidateDeviceCredentialsResponse deviceCredentials, DeviceProfile deviceProfile) throws AdaptorException;

common/transport/coap/src/main/java/org/thingsboard/server/transport/coap/client/DefaultCoapClientContext.java

@@ -81,11 +81,6 @@ public class DefaultCoapClientContext implements CoapClientContext {
         return registerFeatureObservation(clientState, token, exchange, FeatureType.RPC);
     }
 
-    @Override
-    public void onUplink(TransportProtos.SessionInfoProto sessionInfo) {
-        getClientState(toDeviceId(sessionInfo)).updateLastUplinkTime();
-    }
-
     @Override
     public AtomicInteger getNotificationCounterByToken(String token) {
         TbCoapClientState state = clientsByToken.get(token);
@@ -423,7 +418,7 @@ public class DefaultCoapClientContext implements CoapClientContext {
 
         @Override
         public void onToServerRpcResponse(TransportProtos.ToServerRpcResponseMsg msg) {
-
+            log.trace("[{}] Received server rpc response in the wrong session.", state.getSession());
         }
 
         private void cancelObserveRelation(TbCoapObservationState attrs) {
@@ -449,6 +444,7 @@ public class DefaultCoapClientContext implements CoapClientContext {
                 transportService.process(state.getSession(), getSessionEventMsg(TransportProtos.SessionEvent.CLOSED), null);
                 transportService.deregisterSession(state.getSession());
                 state.setSession(null);
+                //TODO: need to delete the client from context as well.
             }
         }
     }
@@ -465,6 +461,7 @@ public class DefaultCoapClientContext implements CoapClientContext {
                 transportService.process(state.getSession(), getSessionEventMsg(TransportProtos.SessionEvent.CLOSED), null);
                 transportService.deregisterSession(state.getSession());
                 state.setSession(null);
+                //TODO: need to delete the client from context as well.
             }
         }
     }

common/transport/coap/src/main/java/org/thingsboard/server/transport/coap/client/TbCoapClientState.java

@@ -18,22 +18,15 @@ package org.thingsboard.server.transport.coap.client;
 import lombok.Data;
 import lombok.Getter;
 import lombok.Setter;
-import org.eclipse.californium.core.network.Exchange;
 import org.thingsboard.server.common.data.id.DeviceId;
 import org.thingsboard.server.common.transport.auth.ValidateDeviceCredentialsResponse;
 import org.thingsboard.server.gen.transport.TransportProtos;
 import org.thingsboard.server.transport.coap.TransportConfigurationContainer;
 import org.thingsboard.server.transport.coap.adaptors.CoapTransportAdaptor;
 
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
 import java.util.concurrent.Future;
-import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
 
 @Data
 public class TbCoapClientState {

common/transport/coap/src/main/java/org/thingsboard/server/transport/coap/efento/CoapEfentoTransportResource.java

@@ -36,9 +36,9 @@ import org.thingsboard.server.gen.transport.TransportProtos;
 import org.thingsboard.server.gen.transport.coap.MeasurementTypeProtos;
 import org.thingsboard.server.gen.transport.coap.MeasurementsProtos;
 import org.thingsboard.server.transport.coap.AbstractCoapTransportResource;
+import org.thingsboard.server.transport.coap.CoapTransportContext;
 import org.thingsboard.server.transport.coap.callback.CoapDeviceAuthCallback;
 import org.thingsboard.server.transport.coap.callback.CoapOkCallback;
-import org.thingsboard.server.transport.coap.CoapTransportContext;
 import org.thingsboard.server.transport.coap.efento.utils.CoapEfentoUtils;
 
 import java.util.ArrayList;