From 47d5aee3dc4a3d88b54e06f814443e34ff4afd05 Mon Sep 17 00:00:00 2001
From: Vladyslav_Prykhodko <vprykhodko@thingsboard.io>
Date: Mon, 19 Oct 2020 19:05:34 +0300
Subject: [PATCH] UI: Improvement alarm widget and fixed timeseries

---
 .../lib/alarms-table-widget.component.ts      |  6 ++---
 .../widget/lib/table-widget.models.ts         |  2 +-
 .../lib/timeseries-table-widget.component.ts  | 22 ++++++++++++-------
 3 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/ui-ngx/src/app/modules/home/components/widget/lib/alarms-table-widget.component.ts b/ui-ngx/src/app/modules/home/components/widget/lib/alarms-table-widget.component.ts
index 26055c55b2..58176a48d1 100644
--- a/ui-ngx/src/app/modules/home/components/widget/lib/alarms-table-widget.component.ts
+++ b/ui-ngx/src/app/modules/home/components/widget/lib/alarms-table-widget.component.ts
@@ -29,7 +29,7 @@ import { PageComponent } from '@shared/components/page.component';
 import { Store } from '@ngrx/store';
 import { AppState } from '@core/core.state';
 import { WidgetAction, WidgetContext } from '@home/models/widget-component.models';
-import { DataKey, Datasource, WidgetActionDescriptor, WidgetConfig } from '@shared/models/widget.models';
+import { DataKey, WidgetActionDescriptor, WidgetConfig } from '@shared/models/widget.models';
 import { IWidgetSubscription } from '@core/api/widget-api.models';
 import { UtilsService } from '@core/services/utils.service';
 import { TranslateService } from '@ngx-translate/core';
@@ -394,7 +394,7 @@ export class AlarmsTableWidgetComponent extends PageComponent implements OnInit,
       this.displayedColumns.push(...this.columns.map(column => column.def));
     }
     if (this.settings.defaultSortOrder && this.settings.defaultSortOrder.length) {
-      this.defaultSortOrder = this.settings.defaultSortOrder;
+      this.defaultSortOrder = this.utils.customTranslation(this.settings.defaultSortOrder, this.settings.defaultSortOrder);
     }
     this.pageLink.sortOrder = entityDataSortOrderFromString(this.defaultSortOrder, this.columns);
     let sortColumn: EntityColumn;
@@ -959,7 +959,7 @@ class AlarmsDatasource implements DataSource<AlarmDataInfo> {
           }
         }
       }
-      alarm[dataKey.name] = value;
+      alarm[dataKey.label] = value;
     });
     return alarm;
   }
diff --git a/ui-ngx/src/app/modules/home/components/widget/lib/table-widget.models.ts b/ui-ngx/src/app/modules/home/components/widget/lib/table-widget.models.ts
index 9e079bc247..1ab9ea6fc4 100644
--- a/ui-ngx/src/app/modules/home/components/widget/lib/table-widget.models.ts
+++ b/ui-ngx/src/app/modules/home/components/widget/lib/table-widget.models.ts
@@ -189,7 +189,7 @@ export function getAlarmValue(alarm: AlarmDataInfo, key: EntityColumn) {
   if (alarmField) {
     return getDescendantProp(alarm, alarmField.value);
   } else {
-    return getDescendantProp(alarm, key.name);
+    return getDescendantProp(alarm, key.label);
   }
 }
 
diff --git a/ui-ngx/src/app/modules/home/components/widget/lib/timeseries-table-widget.component.ts b/ui-ngx/src/app/modules/home/components/widget/lib/timeseries-table-widget.component.ts
index ebf5387862..1b820ab722 100644
--- a/ui-ngx/src/app/modules/home/components/widget/lib/timeseries-table-widget.component.ts
+++ b/ui-ngx/src/app/modules/home/components/widget/lib/timeseries-table-widget.component.ts
@@ -524,16 +524,22 @@ class TimeseriesDatasource implements DataSource<TimeseriesRow> {
       });
     }
 
-    const rows: TimeseriesRow[]  = [];
-
-    for (const value of Object.values(rowsMap)) {
-      if (this.hideEmptyLines && isDefinedAndNotNull(value[1])) {
-        rows.push(value);
-      } else {
-        rows.push(value);
+    let rows: TimeseriesRow[]  = [];
+    if (this.hideEmptyLines) {
+      for (const t of Object.keys(rowsMap)) {
+        let hideLine = true;
+        for (let c = 0; (c < data.length) && hideLine; c++) {
+          if (rowsMap[t][c + 1]) {
+            hideLine = false;
+          }
+        }
+        if (!hideLine) {
+          rows.push(rowsMap[t]);
+        }
       }
+    } else {
+      rows = Object.values(rowsMap);
     }
-
     return rows;
   }