From 54ee0677ad7129b1644eaa10dcb8d8756c5dbb95 Mon Sep 17 00:00:00 2001 From: Andrii Landiak Date: Tue, 16 Jan 2024 09:39:19 +0200 Subject: [PATCH] Renaming SaveEntityEvent variable from added to created. Fix test --- .../server/service/edge/EdgeEventSourcingListener.java | 10 +++++----- .../org/thingsboard/server/edge/AlarmEdgeTest.java | 2 ++ .../server/dao/alarm/BaseAlarmCommentService.java | 2 +- .../thingsboard/server/dao/alarm/BaseAlarmService.java | 2 +- .../server/dao/asset/AssetProfileServiceImpl.java | 2 +- .../thingsboard/server/dao/asset/BaseAssetService.java | 2 +- .../server/dao/customer/CustomerServiceImpl.java | 2 +- .../server/dao/dashboard/DashboardServiceImpl.java | 2 +- .../server/dao/device/DeviceProfileServiceImpl.java | 2 +- .../server/dao/device/DeviceServiceImpl.java | 3 +-- .../server/dao/entityview/EntityViewServiceImpl.java | 2 +- .../server/dao/eventsourcing/SaveEntityEvent.java | 2 +- .../server/dao/ota/BaseOtaPackageService.java | 4 ++-- .../thingsboard/server/dao/queue/BaseQueueService.java | 2 +- .../server/dao/resource/BaseResourceService.java | 2 +- .../server/dao/rule/BaseRuleChainService.java | 2 +- .../server/dao/tenant/TenantProfileServiceImpl.java | 2 +- .../server/dao/tenant/TenantServiceImpl.java | 2 +- .../thingsboard/server/dao/user/UserServiceImpl.java | 2 +- .../server/dao/widget/WidgetTypeServiceImpl.java | 4 ++-- .../server/dao/widget/WidgetsBundleServiceImpl.java | 2 +- 21 files changed, 28 insertions(+), 27 deletions(-) diff --git a/application/src/main/java/org/thingsboard/server/service/edge/EdgeEventSourcingListener.java b/application/src/main/java/org/thingsboard/server/service/edge/EdgeEventSourcingListener.java index 3ed90ee431..ca7048c7e9 100644 --- a/application/src/main/java/org/thingsboard/server/service/edge/EdgeEventSourcingListener.java +++ b/application/src/main/java/org/thingsboard/server/service/edge/EdgeEventSourcingListener.java @@ -79,10 +79,10 @@ public class EdgeEventSourcingListener { return; } log.trace("[{}] SaveEntityEvent called: {}", event.getTenantId(), event); - boolean isAdded = Boolean.TRUE.equals(event.getAdded()); + boolean isCreated = Boolean.TRUE.equals(event.getCreated()); String body = getBodyMsgForEntityEvent(event.getEntity()); EdgeEventType type = getEdgeEventTypeForEntityEvent(event.getEntity()); - EdgeEventActionType action = getActionForEntityEvent(event.getEntity(), isAdded); + EdgeEventActionType action = getActionForEntityEvent(event.getEntity(), isCreated); tbClusterService.sendNotificationMsgToEdge(event.getTenantId(), null, event.getEntityId(), body, type, action, edgeSynchronizationManager.getEdgeId().get()); } catch (Exception e) { @@ -200,10 +200,10 @@ public class EdgeEventSourcingListener { return null; } - private EdgeEventActionType getActionForEntityEvent(Object entity, boolean isAdded) { + private EdgeEventActionType getActionForEntityEvent(Object entity, boolean isCreated) { if (entity instanceof AlarmComment) { - return isAdded ? EdgeEventActionType.ADDED_COMMENT : EdgeEventActionType.UPDATED_COMMENT; + return isCreated ? EdgeEventActionType.ADDED_COMMENT : EdgeEventActionType.UPDATED_COMMENT; } - return isAdded ? EdgeEventActionType.ADDED : EdgeEventActionType.UPDATED; + return isCreated ? EdgeEventActionType.ADDED : EdgeEventActionType.UPDATED; } } diff --git a/application/src/test/java/org/thingsboard/server/edge/AlarmEdgeTest.java b/application/src/test/java/org/thingsboard/server/edge/AlarmEdgeTest.java index acd8cb1444..239cb87ab4 100644 --- a/application/src/test/java/org/thingsboard/server/edge/AlarmEdgeTest.java +++ b/application/src/test/java/org/thingsboard/server/edge/AlarmEdgeTest.java @@ -92,6 +92,7 @@ public class AlarmEdgeTest extends AbstractEdgeTest { alarm.setType("alarm"); alarm.setSeverity(AlarmSeverity.CRITICAL); Alarm savedAlarm = doPost("/api/alarm", alarm, Alarm.class); + edgeImitator.ignoreType(AlarmCommentUpdateMsg.class); // ack alarm edgeImitator.expectMessageAmount(1); @@ -135,6 +136,7 @@ public class AlarmEdgeTest extends AbstractEdgeTest { Assert.assertEquals(savedAlarm.getType(), alarmMsg.getType()); Assert.assertEquals(savedAlarm.getName(), alarmMsg.getName()); Assert.assertEquals(AlarmStatus.CLEARED_ACK, alarmMsg.getStatus()); + edgeImitator.allowIgnoredTypes(); } @Test diff --git a/dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmCommentService.java b/dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmCommentService.java index 042f0f693b..5bdd9803b2 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmCommentService.java +++ b/dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmCommentService.java @@ -61,7 +61,7 @@ public class BaseAlarmCommentService extends AbstractEntityService implements Al } if (result != null) { eventPublisher.publishEvent(SaveEntityEvent.builder().tenantId(tenantId).entity(result) - .entityId(result.getAlarmId()).added(isCreated).build()); + .entityId(result.getAlarmId()).created(isCreated).build()); } return result; } diff --git a/dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmService.java b/dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmService.java index 2a42544bec..72e1b9c7bf 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmService.java +++ b/dao/src/main/java/org/thingsboard/server/dao/alarm/BaseAlarmService.java @@ -135,7 +135,7 @@ public class BaseAlarmService extends AbstractCachedEntityService { private final T entity; private final T oldEntity; private final EntityId entityId; - private final Boolean added; + private final Boolean created; } diff --git a/dao/src/main/java/org/thingsboard/server/dao/ota/BaseOtaPackageService.java b/dao/src/main/java/org/thingsboard/server/dao/ota/BaseOtaPackageService.java index 24539828c9..53a585c358 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/ota/BaseOtaPackageService.java +++ b/dao/src/main/java/org/thingsboard/server/dao/ota/BaseOtaPackageService.java @@ -84,7 +84,7 @@ public class BaseOtaPackageService extends AbstractCachedEntityService