From 574d976b31a76fce60310b4c79b796443f0c0882 Mon Sep 17 00:00:00 2001 From: Dmytro Skarzhynets Date: Tue, 18 Apr 2023 13:05:22 +0300 Subject: [PATCH] Refactor: remove unnecessary no entity details selected tests --- .../metadata/TbGetCustomerDetailsNodeTest.java | 16 ---------------- .../metadata/TbGetTenantDetailsNodeTest.java | 16 ---------------- 2 files changed, 32 deletions(-) diff --git a/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/TbGetCustomerDetailsNodeTest.java b/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/TbGetCustomerDetailsNodeTest.java index e2ab2f7863..afcb3503c9 100644 --- a/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/TbGetCustomerDetailsNodeTest.java +++ b/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/TbGetCustomerDetailsNodeTest.java @@ -143,22 +143,6 @@ public class TbGetCustomerDetailsNodeTest { verify(ctxMock, never()).tellSuccess(any()); } - @Test - public void givenNoEntityDetailsSelected_whenInit_thenException() { - // GIVEN - var expectedExceptionMessage = "No entity details selected!"; - - config.setDetailsList(Collections.emptyList()); - nodeConfiguration = new TbNodeConfiguration(JacksonUtil.valueToTree(config)); - - // WHEN - var exception = assertThrows(TbNodeException.class, () -> node.init(ctxMock, nodeConfiguration)); - - // THEN - assertThat(exception.getMessage()).isEqualTo(expectedExceptionMessage); - verify(ctxMock, never()).tellSuccess(any()); - } - @Test public void givenDefaultConfig_whenInit_thenOK() { assertThat(config.getDetailsList()).isEqualTo(Collections.emptyList()); diff --git a/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/TbGetTenantDetailsNodeTest.java b/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/TbGetTenantDetailsNodeTest.java index 67d70b83bb..cc22e3c2c3 100644 --- a/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/TbGetTenantDetailsNodeTest.java +++ b/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/TbGetTenantDetailsNodeTest.java @@ -95,22 +95,6 @@ public class TbGetTenantDetailsNodeTest { verify(ctxMock, never()).tellSuccess(any()); } - @Test - public void givenNoEntityDetailsSelected_whenInit_thenException() { - // GIVEN - var expectedExceptionMessage = "No entity details selected!"; - - config.setDetailsList(Collections.emptyList()); - nodeConfiguration = new TbNodeConfiguration(JacksonUtil.valueToTree(config)); - - // WHEN - var exception = assertThrows(TbNodeException.class, () -> node.init(ctxMock, nodeConfiguration)); - - // THEN - assertThat(exception.getMessage()).isEqualTo(expectedExceptionMessage); - verify(ctxMock, never()).tellSuccess(any()); - } - @Test public void givenDefaultConfig_whenInit_thenOK() { // THEN