From 35c8ebab54e16cfd3cbb4a7db091577421ca24d2 Mon Sep 17 00:00:00 2001
From: YevhenBondarenko <ybondarenko@thingsboard.io>
Date: Tue, 4 Aug 2020 20:24:37 +0300
Subject: [PATCH] Cassandra ts latest migration improvements

---
 .../CassandraTsLatestToSqlMigrateService.java | 26 +++++++++++++------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/application/src/main/java/org/thingsboard/server/service/install/migrate/CassandraTsLatestToSqlMigrateService.java b/application/src/main/java/org/thingsboard/server/service/install/migrate/CassandraTsLatestToSqlMigrateService.java
index 1e996d3b01..7245617c77 100644
--- a/application/src/main/java/org/thingsboard/server/service/install/migrate/CassandraTsLatestToSqlMigrateService.java
+++ b/application/src/main/java/org/thingsboard/server/service/install/migrate/CassandraTsLatestToSqlMigrateService.java
@@ -29,7 +29,8 @@ import org.thingsboard.server.dao.model.sqlts.dictionary.TsKvDictionaryComposite
 import org.thingsboard.server.dao.model.sqlts.latest.TsKvLatestEntity;
 import org.thingsboard.server.dao.sqlts.dictionary.TsKvDictionaryRepository;
 import org.thingsboard.server.dao.sqlts.insert.latest.InsertLatestTsRepository;
-import org.thingsboard.server.dao.util.NoSqlAnyDao;
+import org.thingsboard.server.dao.util.NoSqlTsDao;
+import org.thingsboard.server.dao.util.SqlTsLatestDao;
 import org.thingsboard.server.service.install.EntityDatabaseSchemaService;
 
 import java.sql.Connection;
@@ -51,11 +52,13 @@ import static org.thingsboard.server.service.install.migrate.CassandraToSqlColum
 
 @Service
 @Profile("install")
-@NoSqlAnyDao
+@NoSqlTsDao
+@SqlTsLatestDao
 @Slf4j
 public class CassandraTsLatestToSqlMigrateService implements TsLatestMigrateService {
 
-    private static final int LATEST_KEY_LENGTH = 255;
+    private static final int MAX_KEY_LENGTH = 255;
+    private static final int MAX_STR_V_LENGTH = 10000000;
 
     @Autowired
     private EntityDatabaseSchemaService entityDatabaseSchemaService;
@@ -95,11 +98,10 @@ public class CassandraTsLatestToSqlMigrateService implements TsLatestMigrateServ
             log.error("Unexpected error during ThingsBoard entities data migration!", e);
             throw e;
         }
-        entityDatabaseSchemaService.createDatabaseIndexes();
     }
 
     private List<CassandraToSqlTable> tables = Arrays.asList(
-            new CassandraToSqlTable("ts_kv_latest_cf",
+            new CassandraToSqlTable("ts_kv_latest_cf", "ts_kv_latest",
                     idColumn("entity_id"),
                     stringColumn("key"),
                     bigintColumn("ts"),
@@ -129,6 +131,12 @@ public class CassandraTsLatestToSqlMigrateService implements TsLatestMigrateServ
 
         String strV = data[4].getValue();
         if (strV != null) {
+            if (strV.length() > MAX_STR_V_LENGTH) {
+                log.warn("[ts_kv_latest] Value size [{}] exceeds maximum size [{}] of column [str_v] and will be truncated!",
+                        strV.length(), MAX_STR_V_LENGTH);
+                log.warn("Affected data:\n{}", strV);
+                strV = strV.substring(0, MAX_STR_V_LENGTH);
+            }
             latestEntity.setStrValue(strV);
         } else {
             Long longV = null;
@@ -170,9 +178,11 @@ public class CassandraTsLatestToSqlMigrateService implements TsLatestMigrateServ
     }
 
     protected Integer getOrSaveKeyId(String strKey) {
-        if (strKey.length() > LATEST_KEY_LENGTH) {
-            log.warn("Key is long. Max key length is 255\n{}", strKey);
-            strKey = strKey.substring(0, LATEST_KEY_LENGTH);
+        if (strKey.length() > MAX_KEY_LENGTH) {
+            log.warn("[ts_kv_latest] Value size [{}] exceeds maximum size [{}] of column [key] and will be truncated!",
+                    strKey.length(), MAX_KEY_LENGTH);
+            log.warn("Affected data:\n{}", strKey);
+            strKey = strKey.substring(0, MAX_KEY_LENGTH);
         }
 
         Integer keyId = tsKvDictionaryMap.get(strKey);