dendi-wang/thingsboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improved PR template

Browse Source
This commit is contained in:
Andrii Shvaika 2022-01-31 09:45:48 +02:00
parent 17ff34645f
commit 94bcd14647
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pull_request_template.md
View File

@ -1,4 +1,6 @@
## PR description ## Pull Request description
Put your PR description here instead of this sentence.
## General checklist ## General checklist
@ -7,17 +9,17 @@
- [ ] Description references specific [issue](https://github.com/thingsboard/thingsboard/issues). - [ ] Description references specific [issue](https://github.com/thingsboard/thingsboard/issues).
- [ ] Description contains human-readable scope of changes. - [ ] Description contains human-readable scope of changes.
- [ ] Description contains brief notes about what needs to be added to the documentation. - [ ] Description contains brief notes about what needs to be added to the documentation.
- [ ] No merge conficts. - [ ] No merge conficts, commented blocks of code, code formatting issues.
- [ ] Changes are backward compatible or upgrade script is provided. - [ ] Changes are backward compatible or upgrade script is provided.
- [ ] Similar PR is opened for PE version to simplify merge. Required for internal contributors only. - [ ] Similar PR is opened for PE version to simplify merge. Required for internal contributors only.
## UI Feature checklist ## Front-End feature checklist
- [ ] Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes; - [ ] Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
- [ ] If you change widget or other API, ensure it is backward-compatible or upgrade script is present. - [ ] If you change widget or other API, ensure it is backward-compatible or upgrade script is present.
- [ ] Ensure new API is documented [here](https://github.com/thingsboard/thingsboard-ui-help) - [ ] Ensure new API is documented [here](https://github.com/thingsboard/thingsboard-ui-help)
## Back-end Feature checklist ## Back-End feature checklist
- [ ] Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests. - [ ] Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
- [ ] If new dependency was added: the dependency tree is checked for conflicts. - [ ] If new dependency was added: the dependency tree is checked for conflicts.