dendi-wang/thingsboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix reference count issue

Browse Source
This commit is contained in:
Andrii Shvaika 2021-08-05 15:10:04 +03:00
parent afdcc6ed3f
commit 9d651a7252
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/MqttTransportHandler.java
View File

@ -237,6 +237,7 @@ public class MqttTransportHandler extends ChannelInboundHandlerAdapter implement
} }
deviceSessionCtx.getMsgQueue().add(msg); deviceSessionCtx.getMsgQueue().add(msg);
ReferenceCountUtil.retain(msg);
processMsgQueue(ctx); //Under the normal conditions the msg queue will contain 0 messages. Many messages will be processed on device connect event in separate thread pool processMsgQueue(ctx); //Under the normal conditions the msg queue will contain 0 messages. Many messages will be processed on device connect event in separate thread pool
} }
@ -252,6 +253,7 @@ public class MqttTransportHandler extends ChannelInboundHandlerAdapter implement
while ((msg = deviceSessionCtx.getMsgQueue().poll()) != null) { while ((msg = deviceSessionCtx.getMsgQueue().poll()) != null) {
deviceSessionCtx.getMsgQueueSize().decrementAndGet(); deviceSessionCtx.getMsgQueueSize().decrementAndGet();
processRegularSessionMsg(ctx, msg); processRegularSessionMsg(ctx, msg);
ReferenceCountUtil.safeRelease(msg);
} }
} finally { } finally {
deviceSessionCtx.getMsgQueueProcessorLock().unlock(); deviceSessionCtx.getMsgQueueProcessorLock().unlock();