diff --git a/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-editor.component.html b/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-editor.component.html index 21ae07c1f6..642f739f8e 100644 --- a/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-editor.component.html +++ b/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-editor.component.html @@ -44,7 +44,7 @@ (ngModelChange)="onActionUpdated()" [fillHeight]="true" [functionArgs]="['$event', 'widgetContext', 'entityId', 'entityName', 'htmlTemplate', 'additionalParams', 'entityLabel']" - [globalVariables]="functionScopeVariables" + [disableUndefinedCheck]="true" [validationArgs]="[]" [editorCompleter]="customPrettyActionEditorCompleter"> diff --git a/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-editor.component.ts b/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-editor.component.ts index c98ee36259..60b28b32da 100644 --- a/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-editor.component.ts +++ b/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-editor.component.ts @@ -36,7 +36,6 @@ import { AppState } from '@core/core.state'; import { combineLatest } from 'rxjs'; import { CustomActionDescriptor } from '@shared/models/widget.models'; import { CustomPrettyActionEditorCompleter } from '@home/components/widget/action/custom-action.models'; -import { WidgetService } from "@core/http/widget.service"; @Component({ selector: 'tb-custom-action-pretty-editor', @@ -59,8 +58,6 @@ export class CustomActionPrettyEditorComponent extends PageComponent implements fullscreen = false; - functionScopeVariables: string[]; - @ViewChildren('leftPanel') leftPanelElmRef: QueryList>; @@ -71,10 +68,8 @@ export class CustomActionPrettyEditorComponent extends PageComponent implements private propagateChange = (_: any) => {}; - constructor(protected store: Store, - private widgetService: WidgetService) { + constructor(protected store: Store) { super(store); - this.functionScopeVariables = this.widgetService.getWidgetScopeVariables(); } ngOnInit(): void { diff --git a/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-resources-tabs.component.html b/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-resources-tabs.component.html index 3bbed25940..d5893c47ab 100644 --- a/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-resources-tabs.component.html +++ b/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-resources-tabs.component.html @@ -94,7 +94,7 @@ [(ngModel)]="action.customFunction" (ngModelChange)="notifyActionUpdated()" [functionArgs]="['$event', 'widgetContext', 'entityId', 'entityName', 'htmlTemplate', 'additionalParams', 'entityLabel']" - [globalVariables]="functionScopeVariables" + [disableUndefinedCheck]="true" [validationArgs]="[]" [editorCompleter]="customPrettyActionEditorCompleter"> diff --git a/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-resources-tabs.component.ts b/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-resources-tabs.component.ts index 5c08fb04fe..1022668fd1 100644 --- a/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-resources-tabs.component.ts +++ b/ui-ngx/src/app/modules/home/components/widget/action/custom-action-pretty-resources-tabs.component.ts @@ -41,7 +41,6 @@ import { forkJoin, from } from 'rxjs'; import { map, tap } from 'rxjs/operators'; import { getAce } from '@shared/models/ace/ace.models'; import { beautifyCss, beautifyHtml } from '@shared/models/beautify.models'; -import { WidgetService } from "@core/http/widget.service"; @Component({ selector: 'tb-custom-action-pretty-resources-tabs', @@ -76,16 +75,12 @@ export class CustomActionPrettyResourcesTabsComponent extends PageComponent impl cssEditor: Ace.Editor; setValuesPending = false; - functionScopeVariables: string[]; - customPrettyActionEditorCompleter = CustomPrettyActionEditorCompleter; constructor(protected store: Store, private translate: TranslateService, - private widgetService: WidgetService, private raf: RafService) { super(store); - this.functionScopeVariables = this.widgetService.getWidgetScopeVariables(); } ngOnInit(): void { diff --git a/ui-ngx/src/app/modules/home/components/widget/action/mobile-action-editor.component.ts b/ui-ngx/src/app/modules/home/components/widget/action/mobile-action-editor.component.ts index ac6b6d9577..75c42e7375 100644 --- a/ui-ngx/src/app/modules/home/components/widget/action/mobile-action-editor.component.ts +++ b/ui-ngx/src/app/modules/home/components/widget/action/mobile-action-editor.component.ts @@ -36,7 +36,7 @@ import { getDefaultProcessLocationFunction, getDefaultProcessQrCodeFunction } from '@home/components/widget/action/mobile-action-editor.models'; -import { WidgetService } from "@core/http/widget.service"; +import { WidgetService } from '@core/http/widget.service'; @Component({ selector: 'tb-mobile-action-editor', diff --git a/ui-ngx/src/app/modules/home/components/widget/action/widget-action-dialog.component.ts b/ui-ngx/src/app/modules/home/components/widget/action/widget-action-dialog.component.ts index 7a70c50b0e..d8633c9aff 100644 --- a/ui-ngx/src/app/modules/home/components/widget/action/widget-action-dialog.component.ts +++ b/ui-ngx/src/app/modules/home/components/widget/action/widget-action-dialog.component.ts @@ -47,7 +47,7 @@ import { CustomActionEditorCompleter } from '@home/components/widget/action/cust import { isDefinedAndNotNull } from '@core/utils'; import { MobileActionEditorComponent } from '@home/components/widget/action/mobile-action-editor.component'; import { widgetType } from '@shared/models/widget.models'; -import { WidgetService } from "@core/http/widget.service"; +import { WidgetService } from '@core/http/widget.service'; export interface WidgetActionDialogData { isAdd: boolean; diff --git a/ui-ngx/src/app/modules/home/components/widget/data-key-config.component.ts b/ui-ngx/src/app/modules/home/components/widget/data-key-config.component.ts index 23aced69c7..db40968a1c 100644 --- a/ui-ngx/src/app/modules/home/components/widget/data-key-config.component.ts +++ b/ui-ngx/src/app/modules/home/components/widget/data-key-config.component.ts @@ -40,7 +40,7 @@ import { map, mergeMap, publishReplay, refCount, tap } from 'rxjs/operators'; import { alarmFields } from '@shared/models/alarm.models'; import { JsFuncComponent } from '@shared/components/js-func.component'; import { JsonFormComponentData } from '@shared/components/json-form/json-form-component.models'; -import { WidgetService } from "@core/http/widget.service"; +import { WidgetService } from '@core/http/widget.service'; @Component({ selector: 'tb-data-key-config', diff --git a/ui-ngx/src/app/shared/components/js-func.component.ts b/ui-ngx/src/app/shared/components/js-func.component.ts index abc0bc0d21..9ba2428e44 100644 --- a/ui-ngx/src/app/shared/components/js-func.component.ts +++ b/ui-ngx/src/app/shared/components/js-func.component.ts @@ -85,6 +85,8 @@ export class JsFuncComponent implements OnInit, OnDestroy, ControlValueAccessor, @Input() globalVariables: Array; + @Input() disableUndefinedCheck = false; + private noValidateValue: boolean; get noValidate(): boolean { return this.noValidateValue; @@ -167,32 +169,34 @@ export class JsFuncComponent implements OnInit, OnDestroy, ControlValueAccessor, this.updateView(); } }); - // @ts-ignore - this.jsEditor.session.on('changeAnnotation', () => { - const annotations = this.jsEditor.session.getAnnotations(); - annotations.filter(annotation => annotation.text.includes('is not defined')).forEach(annotation => { - annotation.type = 'error'; + if (!this.disableUndefinedCheck) { + // @ts-ignore + this.jsEditor.session.on('changeAnnotation', () => { + const annotations = this.jsEditor.session.getAnnotations(); + annotations.filter(annotation => annotation.text.includes('is not defined')).forEach(annotation => { + annotation.type = 'error'; + }); + this.jsEditor.renderer.setAnnotations(annotations); + const hasErrors = annotations.filter(annotation => annotation.type === 'error').length > 0; + if (this.hasErrors !== hasErrors) { + this.hasErrors = hasErrors; + this.propagateChange(this.modelValue); + } }); - this.jsEditor.renderer.setAnnotations(annotations); - const hasErrors = annotations.filter(annotation => annotation.type === 'error').length > 0; - if (this.hasErrors !== hasErrors) { - this.hasErrors = hasErrors; - this.propagateChange(this.modelValue); - } - }); + } // @ts-ignore if (!!this.jsEditor.session.$worker) { const jsWorkerOptions = { - undef: true, + undef: !this.disableUndefinedCheck, unused: true, globals: {} }; - if (this.functionArgs) { + if (!this.disableUndefinedCheck && this.functionArgs) { this.functionArgs.forEach(arg => { jsWorkerOptions.globals[arg] = false; }); } - if (this.globalVariables) { + if (!this.disableUndefinedCheck && this.globalVariables) { this.globalVariables.forEach(arg => { jsWorkerOptions.globals[arg] = false; });