From bc88babd1120db4a43e41212cf8cfa65d8edb7e1 Mon Sep 17 00:00:00 2001
From: thingsboard <adovhopolyi@thingsboard.com>
Date: Tue, 12 Jul 2022 12:29:27 +0300
Subject: [PATCH] fix pr comments

---
 .../server/service/action/EntityActionService.java     |  7 ++++++-
 common/data/pom.xml                                    | 10 ----------
 .../thingsboard/server/common/data/StringUtils.java    |  8 ++------
 .../server/transport/mqtt/MqttTransportHandler.java    |  2 +-
 4 files changed, 9 insertions(+), 18 deletions(-)

diff --git a/application/src/main/java/org/thingsboard/server/service/action/EntityActionService.java b/application/src/main/java/org/thingsboard/server/service/action/EntityActionService.java
index 2f18fb56c8..e1e7ffbb55 100644
--- a/application/src/main/java/org/thingsboard/server/service/action/EntityActionService.java
+++ b/application/src/main/java/org/thingsboard/server/service/action/EntityActionService.java
@@ -23,7 +23,12 @@ import lombok.extern.slf4j.Slf4j;
 
 import org.springframework.stereotype.Service;
 import org.thingsboard.server.cluster.TbClusterService;
-import org.thingsboard.server.common.data.*;
+import org.thingsboard.server.common.data.DataConstants;
+import org.thingsboard.server.common.data.EntityType;
+import org.thingsboard.server.common.data.HasName;
+import org.thingsboard.server.common.data.HasTenantId;
+import org.thingsboard.server.common.data.User;
+import org.thingsboard.server.common.data.StringUtils;
 import org.thingsboard.server.common.data.audit.ActionType;
 import org.thingsboard.server.common.data.edge.EdgeEventActionType;
 import org.thingsboard.server.common.data.id.CustomerId;
diff --git a/common/data/pom.xml b/common/data/pom.xml
index 50755115a0..539dd0d9e3 100644
--- a/common/data/pom.xml
+++ b/common/data/pom.xml
@@ -108,16 +108,6 @@
             <groupId>de.ruedigermoeller</groupId>
             <artifactId>fst</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.eclipse.leshan</groupId>
-            <artifactId>leshan-core</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>com.amazonaws</groupId>
-            <artifactId>aws-java-sdk-core</artifactId>
-            <version>1.11.747</version>
-            <scope>compile</scope>
-        </dependency>
     </dependencies>
 
     <build>
diff --git a/common/data/src/main/java/org/thingsboard/server/common/data/StringUtils.java b/common/data/src/main/java/org/thingsboard/server/common/data/StringUtils.java
index 4b916df30e..77e4e7656c 100644
--- a/common/data/src/main/java/org/thingsboard/server/common/data/StringUtils.java
+++ b/common/data/src/main/java/org/thingsboard/server/common/data/StringUtils.java
@@ -17,13 +17,9 @@ package org.thingsboard.server.common.data;
 
 import com.google.common.base.Splitter;
 
-import java.nio.charset.Charset;
-
 import static org.apache.commons.lang3.StringUtils.repeat;
 
 public class StringUtils {
-    public static Charset UTF8 = com.amazonaws.util.StringUtils.UTF8;
-
     public static final String EMPTY = "";
 
     public static final int INDEX_NOT_FOUND = -1;
@@ -101,8 +97,8 @@ public class StringUtils {
         return Splitter.fixedLength(maxPartSize).split(value);
     }
 
-    public static boolean equalsIgnoreCase(String value, String aTrue) {
-        return org.eclipse.leshan.core.util.StringUtils.equalsIgnoreCase(value, aTrue);
+    public static boolean equalsIgnoreCase(String str1, String str2) {
+        return str1 == null ? str2 == null : str1.equalsIgnoreCase(str2);
     }
 
     public static String join(String[] keyArray, String lwm2mSeparatorPath) {
diff --git a/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/MqttTransportHandler.java b/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/MqttTransportHandler.java
index b83cb4aa44..ad07c9f9a4 100644
--- a/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/MqttTransportHandler.java
+++ b/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/MqttTransportHandler.java
@@ -89,7 +89,7 @@ import java.util.concurrent.TimeUnit;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import static org.thingsboard.server.common.data.StringUtils.UTF8;
+import static com.amazonaws.util.StringUtils.UTF8;
 import static io.netty.handler.codec.mqtt.MqttConnectReturnCode.CONNECTION_ACCEPTED;
 import static io.netty.handler.codec.mqtt.MqttConnectReturnCode.CONNECTION_REFUSED_NOT_AUTHORIZED;
 import static io.netty.handler.codec.mqtt.MqttMessageType.CONNACK;