dendi-wang/thingsboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

removed one level of nesting in transformSuccess method

Browse Source
This commit is contained in:
ShvaykaD 2023-06-02 11:50:31 +03:00
parent 2f95ea444c
commit c4c7224dd0
1 changed files with 16 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
rule-engine/rule-engine-components/src/main/java/org/thingsboard/rule/engine/transform/TbAbstractTransformNode.java
View File

@ -60,8 +60,9 @@ public abstract class TbAbstractTransformNode<C> implements TbNode {
} }
protected void transformSuccess(TbContext ctx, TbMsg msg, List<TbMsg> msgs) { protected void transformSuccess(TbContext ctx, TbMsg msg, List<TbMsg> msgs) {
if (msgs != null && !msgs.isEmpty()) { if (msgs == null || msgs.isEmpty()) {
if (msgs.size() == 1) { ctx.tellFailure(msg, new RuntimeException("Message or messages list are empty!"));
} else if (msgs.size() == 1) {
ctx.tellSuccess(msgs.get(0)); ctx.tellSuccess(msgs.get(0));
} else { } else {
TbMsgCallbackWrapper wrapper = new MultipleTbMsgsCallbackWrapper(msgs.size(), new TbMsgCallback() { TbMsgCallbackWrapper wrapper = new MultipleTbMsgsCallbackWrapper(msgs.size(), new TbMsgCallback() {
@ -77,9 +78,6 @@ public abstract class TbAbstractTransformNode<C> implements TbNode {
}); });
msgs.forEach(newMsg -> ctx.enqueueForTellNext(newMsg, TbRelationTypes.SUCCESS, wrapper::onSuccess, wrapper::onFailure)); msgs.forEach(newMsg -> ctx.enqueueForTellNext(newMsg, TbRelationTypes.SUCCESS, wrapper::onSuccess, wrapper::onFailure));
} }
} else {
ctx.tellFailure(msg, new RuntimeException("Message or messages list are empty!"));
}
} }
protected abstract ListenableFuture<List<TbMsg>> transform(TbContext ctx, TbMsg msg); protected abstract ListenableFuture<List<TbMsg>> transform(TbContext ctx, TbMsg msg);