From ced8ff5bd6913b2045ebe7f2cfcbf84919b86ac2 Mon Sep 17 00:00:00 2001 From: Vladyslav_Prykhodko Date: Mon, 27 Jun 2022 14:29:57 +0300 Subject: [PATCH] UI: Improvement VC in mobile mode, fixed catch error message and add validation space in commit message --- .../http/entities-version-control.service.ts | 6 +- .../vc/auto-commit-settings.component.html | 109 +++++++------- .../vc/auto-commit-settings.component.scss | 5 - .../vc/complex-version-create.component.html | 5 +- .../vc/complex-version-create.component.ts | 6 +- .../vc/complex-version-load.component.html | 2 +- ...entity-types-version-create.component.html | 142 +++++++++--------- ...entity-types-version-create.component.scss | 5 - .../entity-types-version-load.component.html | 112 +++++++------- .../entity-types-version-load.component.scss | 5 - .../vc/entity-version-create.component.html | 5 +- .../vc/entity-version-create.component.ts | 2 +- .../vc/entity-version-diff.component.scss | 1 + .../vc/entity-version-diff.component.ts | 2 +- .../vc/entity-version-restore.component.html | 2 +- .../vc/entity-versions-table.component.html | 58 +++---- .../vc/entity-versions-table.component.ts | 18 ++- .../vc/repository-settings.component.scss | 5 + ui-ngx/src/app/shared/models/vc.models.ts | 7 +- .../assets/locale/locale.constant-en_US.json | 4 +- 20 files changed, 253 insertions(+), 248 deletions(-) diff --git a/ui-ngx/src/app/core/http/entities-version-control.service.ts b/ui-ngx/src/app/core/http/entities-version-control.service.ts index d7e892f1db..c8a9ff327b 100644 --- a/ui-ngx/src/app/core/http/entities-version-control.service.ts +++ b/ui-ngx/src/app/core/http/entities-version-control.service.ts @@ -38,11 +38,10 @@ import { EntityType, entityTypeTranslations } from '@shared/models/entity-type.m import { select, Store } from '@ngrx/store'; import { AppState } from '@core/core.state'; import { selectIsUserLoaded } from '@core/auth/auth.selectors'; -import { catchError, finalize, map, switchMap, takeWhile, tap } from 'rxjs/operators'; +import { catchError, finalize, switchMap, takeWhile, tap } from 'rxjs/operators'; import { TranslateService } from '@ngx-translate/core'; import { DomSanitizer, SafeHtml } from '@angular/platform-browser'; import { ActionLoadFinish, ActionLoadStart } from '@core/interceptors/load.actions'; -import { NULL_UUID } from '@shared/models/id/has-uuid'; @Injectable({ providedIn: 'root' @@ -184,6 +183,9 @@ export class EntitiesVersionControlService { (this.translate.instant(entityTypeTranslations.get(entityLoadError.target.entityType).type) as string).toLowerCase(); messageArgs.targetEntityId = entityLoadError.target.id; break; + case EntityLoadErrorType.RUNTIME: + messageArgs.message = entityLoadError.message.toLowerCase(); + break; } return this.sanitizer.bypassSecurityTrustHtml(this.translate.instant(messageId, messageArgs)); } diff --git a/ui-ngx/src/app/modules/home/components/vc/auto-commit-settings.component.html b/ui-ngx/src/app/modules/home/components/vc/auto-commit-settings.component.html index b04ab515ae..6529b4b97b 100644 --- a/ui-ngx/src/app/modules/home/components/vc/auto-commit-settings.component.html +++ b/ui-ngx/src/app/modules/home/components/vc/auto-commit-settings.component.html @@ -32,64 +32,63 @@
admin.auto-commit-entities
-
-
- - -
- -
-
-
-
- - -
-
- -
- -
-
- - -
- - -
-
-
- - {{ 'version-control.export-credentials' | translate }} - - - {{ 'version-control.export-attributes' | translate }} - - - {{ 'version-control.export-relations' | translate }} - +
+ + +
+ +
+
+
+
+ + +
+
+ +
+ +
+
+ + +
+ +
+
+ + {{ 'version-control.export-credentials' | translate }} + + + {{ 'version-control.export-attributes' | translate }} + + + {{ 'version-control.export-relations' | translate }} + +
- - -
+
+ +
-
+

{{ 'version-control.create-entities-version' | translate }}

@@ -35,7 +35,8 @@ version-control.version-name - + {{ 'version-control.version-name-required' | translate }} diff --git a/ui-ngx/src/app/modules/home/components/vc/complex-version-create.component.ts b/ui-ngx/src/app/modules/home/components/vc/complex-version-create.component.ts index 5348b4b340..8b53bdaeac 100644 --- a/ui-ngx/src/app/modules/home/components/vc/complex-version-create.component.ts +++ b/ui-ngx/src/app/modules/home/components/vc/complex-version-create.component.ts @@ -20,7 +20,9 @@ import { FormBuilder, FormGroup, Validators } from '@angular/forms'; import { ComplexVersionCreateRequest, createDefaultEntityTypesVersionCreate, - SyncStrategy, syncStrategyHintMap, syncStrategyTranslationMap, + SyncStrategy, + syncStrategyHintMap, + syncStrategyTranslationMap, VersionCreateRequestType, VersionCreationResult } from '@shared/models/vc.models'; @@ -82,7 +84,7 @@ export class ComplexVersionCreateComponent extends PageComponent implements OnIn ngOnInit(): void { this.createVersionFormGroup = this.fb.group({ branch: [this.branch, [Validators.required]], - versionName: [null, [Validators.required]], + versionName: [null, [Validators.required, Validators.pattern(/(?:.|\s)*\S(&:.|\s)*/)]], syncStrategy: [SyncStrategy.MERGE, Validators.required], entityTypes: [createDefaultEntityTypesVersionCreate(), []], }); diff --git a/ui-ngx/src/app/modules/home/components/vc/complex-version-load.component.html b/ui-ngx/src/app/modules/home/components/vc/complex-version-load.component.html index 05f16b3e2a..2df32ec5e2 100644 --- a/ui-ngx/src/app/modules/home/components/vc/complex-version-load.component.html +++ b/ui-ngx/src/app/modules/home/components/vc/complex-version-load.component.html @@ -15,7 +15,7 @@ limitations under the License. --> -
+

{{ 'version-control.restore-entities-from-version' | translate: {versionName} }}

diff --git a/ui-ngx/src/app/modules/home/components/vc/entity-types-version-create.component.html b/ui-ngx/src/app/modules/home/components/vc/entity-types-version-create.component.html index 928b7a7668..89b2a67c4d 100644 --- a/ui-ngx/src/app/modules/home/components/vc/entity-types-version-create.component.html +++ b/ui-ngx/src/app/modules/home/components/vc/entity-types-version-create.component.html @@ -19,81 +19,79 @@
version-control.entities-to-export
-
-
- - -
- -
-
{{ entityTypeText(entityTypeFormGroup) }}
-
-
- - -
-
- -
- -
- - -
- - version-control.sync-strategy - - - {{ 'version-control.default' | translate }} - - - {{syncStrategyTranslations.get(strategy) | translate}} - - - -
- - {{ 'version-control.export-credentials' | translate }} - - - {{ 'version-control.export-attributes' | translate }} - - - {{ 'version-control.export-relations' | translate }} - -
+
+ + +
+ +
+
{{ entityTypeText(entityTypeFormGroup) }}
+
+
+ + +
+
+ +
+ +
+ + +
+ + version-control.sync-strategy + + + {{ 'version-control.default' | translate }} + + + {{syncStrategyTranslations.get(strategy) | translate}} + + + +
+ + {{ 'version-control.export-credentials' | translate }} + + + {{ 'version-control.export-attributes' | translate }} + + + {{ 'version-control.export-relations' | translate }} +
-
- - {{ 'version-control.all-entities' | translate }} - - - -
- - -
+
+ + {{ 'version-control.all-entities' | translate }} + + + +
+
+ +
version-control.entities-to-restore
-
-
- - -
- -
-
{{ entityTypeText(entityTypeFormGroup) }}
+
+ + +
+ +
+
{{ entityTypeText(entityTypeFormGroup) }}
+
+
+ + +
+
+ +
+ +
+ + +
+
+ + {{ 'version-control.remove-other-entities' | translate }} + + + {{ 'version-control.find-existing-entity-by-name' | translate }} +
- - - -
- - -
- -
- - -
-
- - {{ 'version-control.remove-other-entities' | translate }} - - - {{ 'version-control.find-existing-entity-by-name' | translate }} - -
-
- - {{ 'version-control.load-credentials' | translate }} - - - {{ 'version-control.load-attributes' | translate }} - - - {{ 'version-control.load-relations' | translate }} - -
+
+ + {{ 'version-control.load-credentials' | translate }} + + + {{ 'version-control.load-attributes' | translate }} + + + {{ 'version-control.load-relations' | translate }} +
- - -
+
+ +
-
+

{{ 'version-control.create-entity-version' | translate }}

@@ -34,7 +34,8 @@ version-control.version-name - + {{ 'version-control.version-name-required' | translate }} diff --git a/ui-ngx/src/app/modules/home/components/vc/entity-version-create.component.ts b/ui-ngx/src/app/modules/home/components/vc/entity-version-create.component.ts index 6706d80c71..0b8812f94d 100644 --- a/ui-ngx/src/app/modules/home/components/vc/entity-version-create.component.ts +++ b/ui-ngx/src/app/modules/home/components/vc/entity-version-create.component.ts @@ -80,7 +80,7 @@ export class EntityVersionCreateComponent extends PageComponent implements OnIni this.createVersionFormGroup = this.fb.group({ branch: [this.branch, [Validators.required]], versionName: [this.translate.instant('version-control.default-create-entity-version-name', - {entityName: this.entityName}), [Validators.required]], + {entityName: this.entityName}), [Validators.required, Validators.pattern(/(?:.|\s)*\S(&:.|\s)*/)]], saveRelations: [false, []], saveAttributes: [true, []], saveCredentials: [true, []] diff --git a/ui-ngx/src/app/modules/home/components/vc/entity-version-diff.component.scss b/ui-ngx/src/app/modules/home/components/vc/entity-version-diff.component.scss index cf0bf939b7..e3efdc871b 100644 --- a/ui-ngx/src/app/modules/home/components/vc/entity-version-diff.component.scss +++ b/ui-ngx/src/app/modules/home/components/vc/entity-version-diff.component.scss @@ -19,6 +19,7 @@ .entity-version-diff-view { position: relative; &:not(.tb-fullscreen) { + max-height: 95vh; &.content-ready { width: 600px; @media #{$mat-gt-sm} { diff --git a/ui-ngx/src/app/modules/home/components/vc/entity-version-diff.component.ts b/ui-ngx/src/app/modules/home/components/vc/entity-version-diff.component.ts index 29955af18e..c93d970448 100644 --- a/ui-ngx/src/app/modules/home/components/vc/entity-version-diff.component.ts +++ b/ui-ngx/src/app/modules/home/components/vc/entity-version-diff.component.ts @@ -161,7 +161,7 @@ export class EntityVersionDiffComponent extends PageComponent implements OnInit, setTimeout(() => { this.diffCount = this.differ.getNumDiffs(); this.updateHasNextAndPrevious(); - }); + }, 1); }); }); }); diff --git a/ui-ngx/src/app/modules/home/components/vc/entity-version-restore.component.html b/ui-ngx/src/app/modules/home/components/vc/entity-version-restore.component.html index b096c1907f..cbd2c72c31 100644 --- a/ui-ngx/src/app/modules/home/components/vc/entity-version-restore.component.html +++ b/ui-ngx/src/app/modules/home/components/vc/entity-version-restore.component.html @@ -15,7 +15,7 @@ limitations under the License. --> -
+

{{ 'version-control.restore-entity-from-version' | translate: {versionName} }}

diff --git a/ui-ngx/src/app/modules/home/components/vc/entity-versions-table.component.html b/ui-ngx/src/app/modules/home/components/vc/entity-versions-table.component.html index b6accc40dc..2f3abbb12c 100644 --- a/ui-ngx/src/app/modules/home/components/vc/entity-versions-table.component.html +++ b/ui-ngx/src/app/modules/home/components/vc/entity-versions-table.component.html @@ -31,32 +31,36 @@
- - - - +
+ + +
+ + +
+
@@ -70,7 +74,7 @@   + placeholder="{{ 'version-control.search' | translate }}"/>