From d0090f8b7a195de25416f39cef059e4d84fb334f Mon Sep 17 00:00:00 2001
From: Andrii Landiak <andriylandiak@gmail.com>
Date: Mon, 7 Nov 2022 17:52:44 +0200
Subject: [PATCH] Removed unnecessary unused case for DataUpdateService

---
 .../server/install/ThingsboardInstallService.java      |  1 +
 .../install/update/DefaultDataUpdateService.java       | 10 ----------
 .../server/controller/BaseAuditLogControllerTest.java  |  1 +
 .../server/dao/sql/edge/EdgeEventInsertRepository.java |  2 --
 .../server/dao/sql/edge/JpaBaseEdgeEventDao.java       |  1 +
 5 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/application/src/main/java/org/thingsboard/server/install/ThingsboardInstallService.java b/application/src/main/java/org/thingsboard/server/install/ThingsboardInstallService.java
index 39953ef014..33a6d4bdd1 100644
--- a/application/src/main/java/org/thingsboard/server/install/ThingsboardInstallService.java
+++ b/application/src/main/java/org/thingsboard/server/install/ThingsboardInstallService.java
@@ -232,6 +232,7 @@ public class ThingsboardInstallService {
                             log.info("Updating system data...");
                             systemDataLoaderService.updateSystemWidgets();
                             break;
+
                         //TODO update CacheCleanupService on the next version upgrade
 
                         default:
diff --git a/application/src/main/java/org/thingsboard/server/service/install/update/DefaultDataUpdateService.java b/application/src/main/java/org/thingsboard/server/service/install/update/DefaultDataUpdateService.java
index 68c1c50140..ea6d278844 100644
--- a/application/src/main/java/org/thingsboard/server/service/install/update/DefaultDataUpdateService.java
+++ b/application/src/main/java/org/thingsboard/server/service/install/update/DefaultDataUpdateService.java
@@ -202,16 +202,6 @@ public class DefaultDataUpdateService implements DataUpdateService {
                     log.info("Skipping edge events migration");
                 }
                 break;
-            case "3.5.0":
-                boolean skipEdgeEventsMigration = getEnv("TB_SKIP_EDGE_EVENTS_MIGRATION", false);
-                if (!skipEdgeEventsMigration) {
-                    log.info("Updating data from version 3.4.2 to 3.5.0 ...");
-                    log.info("Starting edge events migration. Can be skipped with TB_SKIP_EDGE_EVENTS_MIGRATION env variable set to true");
-                    edgeEventDao.migrateEdgeEvents();
-                } else {
-                    log.info("Skipping edge events migration");
-                }
-                break;
             default:
                 throw new RuntimeException("Unable to update data, unsupported fromVersion: " + fromVersion);
         }
diff --git a/application/src/test/java/org/thingsboard/server/controller/BaseAuditLogControllerTest.java b/application/src/test/java/org/thingsboard/server/controller/BaseAuditLogControllerTest.java
index 4f8d07864b..c46f7d9c46 100644
--- a/application/src/test/java/org/thingsboard/server/controller/BaseAuditLogControllerTest.java
+++ b/application/src/test/java/org/thingsboard/server/controller/BaseAuditLogControllerTest.java
@@ -178,6 +178,7 @@ public abstract class BaseAuditLogControllerTest extends AbstractControllerTest
         reset(partitioningRepository);
         AuditLog auditLog = createAuditLog(ActionType.LOGIN, tenantAdminUserId);
         verify(partitioningRepository).createPartitionIfNotExists(eq("audit_log"), eq(auditLog.getCreatedTime()), eq(partitionDurationInMs));
+
         List<Long> partitions = partitioningRepository.fetchPartitions("audit_log");
         assertThat(partitions).singleElement().satisfies(partitionStartTs -> {
             assertThat(partitionStartTs).isEqualTo(partitioningRepository.calculatePartitionStartTime(auditLog.getCreatedTime(), partitionDurationInMs));
diff --git a/dao/src/main/java/org/thingsboard/server/dao/sql/edge/EdgeEventInsertRepository.java b/dao/src/main/java/org/thingsboard/server/dao/sql/edge/EdgeEventInsertRepository.java
index ec7a6ccfab..694d68556f 100644
--- a/dao/src/main/java/org/thingsboard/server/dao/sql/edge/EdgeEventInsertRepository.java
+++ b/dao/src/main/java/org/thingsboard/server/dao/sql/edge/EdgeEventInsertRepository.java
@@ -51,11 +51,9 @@ public class EdgeEventInsertRepository {
             protected void doInTransactionWithoutResult(TransactionStatus status) {
                 jdbcTemplate.batchUpdate(INSERT, new BatchPreparedStatementSetter() {
                     @Override
-
                     public void setValues(PreparedStatement ps, int i) throws SQLException {
                         EdgeEventEntity edgeEvent = entities.get(i);
                         ps.setObject(1, edgeEvent.getId());
-
                         ps.setLong(2, edgeEvent.getCreatedTime());
                         ps.setObject(3, edgeEvent.getEdgeId());
                         ps.setString(4, edgeEvent.getEdgeEventType().name());
diff --git a/dao/src/main/java/org/thingsboard/server/dao/sql/edge/JpaBaseEdgeEventDao.java b/dao/src/main/java/org/thingsboard/server/dao/sql/edge/JpaBaseEdgeEventDao.java
index 334d5a5671..a0efcde00e 100644
--- a/dao/src/main/java/org/thingsboard/server/dao/sql/edge/JpaBaseEdgeEventDao.java
+++ b/dao/src/main/java/org/thingsboard/server/dao/sql/edge/JpaBaseEdgeEventDao.java
@@ -86,6 +86,7 @@ public class JpaBaseEdgeEventDao extends JpaAbstractSearchTextDao<EdgeEventEntit
     private long edge_events_ttl;
 
     private static final String TABLE_NAME = ModelConstants.EDGE_EVENT_COLUMN_FAMILY_NAME;
+
     private TbSqlBlockingQueueWrapper<EdgeEventEntity> queue;
 
     @Override