dendi-wang/thingsboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use a callback to log errors on failure for improved error reporting

Browse Source
This commit is contained in:
Dmytro Skarzhynets 2025-06-06 18:58:14 +03:00
parent 8dc9a68c62
commit d917c72d51
No known key found for this signature in database
GPG Key ID: 2B51652F224037DF
1 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
application/src/main/java/org/thingsboard/server/service/state/DefaultDeviceStateService.java
View File

@ -604,7 +604,9 @@ public class DefaultDeviceStateService extends AbstractPartitionBasedService<Dev
var tenantId = stateData.getTenantId(); var tenantId = stateData.getTenantId();
var deviceId = stateData.getDeviceId(); var deviceId = stateData.getDeviceId();
Futures.whenAllSucceed(save(tenantId, deviceId, ACTIVITY_STATE, active)).run(() -> { Futures.addCallback(save(tenantId, deviceId, ACTIVITY_STATE, active), new FutureCallback<>() {
@Override
public void onSuccess(Void success) {
stateData.getState().setActive(active); stateData.getState().setActive(active);
pushRuleEngineMessage(stateData, active ? TbMsgType.ACTIVITY_EVENT : TbMsgType.INACTIVITY_EVENT); pushRuleEngineMessage(stateData, active ? TbMsgType.ACTIVITY_EVENT : TbMsgType.INACTIVITY_EVENT);
TbMsgMetaData metaData = stateData.getMetaData(); TbMsgMetaData metaData = stateData.getMetaData();
@ -617,6 +619,12 @@ public class DefaultDeviceStateService extends AbstractPartitionBasedService<Dev
.deviceType(metaData.getValue("deviceType")) .deviceType(metaData.getValue("deviceType"))
.deviceLabel(metaData.getValue("deviceLabel")) .deviceLabel(metaData.getValue("deviceLabel"))
.build()); .build());
}
@Override
public void onFailure(@NonNull Throwable t) {
log.error("[{}][{}] Failed to change device activity status to '{}'. Device state data: {}", tenantId, deviceId, active, stateData, t);
}
}, deviceStateCallbackExecutor); }, deviceStateCallbackExecutor);
} }