diff --git a/application/src/test/java/org/thingsboard/server/transport/mqtt/mqttv3/telemetry/timeseries/AbstractMqttTimeseriesIntegrationTest.java b/application/src/test/java/org/thingsboard/server/transport/mqtt/mqttv3/telemetry/timeseries/AbstractMqttTimeseriesIntegrationTest.java index 4f89a8018e..32854a8735 100644 --- a/application/src/test/java/org/thingsboard/server/transport/mqtt/mqttv3/telemetry/timeseries/AbstractMqttTimeseriesIntegrationTest.java +++ b/application/src/test/java/org/thingsboard/server/transport/mqtt/mqttv3/telemetry/timeseries/AbstractMqttTimeseriesIntegrationTest.java @@ -57,7 +57,7 @@ import static org.thingsboard.server.common.data.device.profile.MqttTopics.DEVIC import static org.thingsboard.server.common.data.device.profile.MqttTopics.GATEWAY_CONNECT_TOPIC; import static org.thingsboard.server.common.data.device.profile.MqttTopics.GATEWAY_METRICS_TOPIC; import static org.thingsboard.server.common.data.device.profile.MqttTopics.GATEWAY_TELEMETRY_TOPIC; -import static org.thingsboard.server.transport.mqtt.gateway.GatewayMetricsService.METRICS_CHECK; +import static org.thingsboard.server.transport.mqtt.gateway.GatewayMetricsService.GATEWAY_METRICS; @Slf4j public abstract class AbstractMqttTimeseriesIntegrationTest extends AbstractMqttIntegrationTest { @@ -148,13 +148,13 @@ public abstract class AbstractMqttTimeseriesIntegrationTest extends AbstractMqtt gatewayMetricsService.reportMetrics(); - List actualKeys = getActualKeysList(savedGateway.getId(), List.of(METRICS_CHECK)); - assertEquals(METRICS_CHECK, actualKeys.get(0)); + List actualKeys = getActualKeysList(savedGateway.getId(), List.of(GATEWAY_METRICS)); + assertEquals(GATEWAY_METRICS, actualKeys.get(0)); - String telemetryUrl = String.format("/api/plugins/telemetry/DEVICE/%s/values/timeseries?startTs=%d&endTs=%d&keys=%s", savedGateway.getId(), 0, System.currentTimeMillis(), METRICS_CHECK); + String telemetryUrl = String.format("/api/plugins/telemetry/DEVICE/%s/values/timeseries?startTs=%d&endTs=%d&keys=%s", savedGateway.getId(), 0, System.currentTimeMillis(), GATEWAY_METRICS); Map>> gatewayTelemetry = doGetAsyncTyped(telemetryUrl, new TypeReference<>() {}); - Map latencyCheckTelemetry = gatewayTelemetry.get(METRICS_CHECK).get(0); + Map latencyCheckTelemetry = gatewayTelemetry.get(GATEWAY_METRICS).get(0); Map latencyCheckValue = JacksonUtil.fromString((String) latencyCheckTelemetry.get("value"), new TypeReference<>() {}); assertNotNull(latencyCheckValue); diff --git a/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/MqttTransportHandler.java b/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/MqttTransportHandler.java index 1eee03f722..7fad363c6b 100644 --- a/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/MqttTransportHandler.java +++ b/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/MqttTransportHandler.java @@ -424,7 +424,7 @@ public class MqttTransportHandler extends ChannelInboundHandlerAdapter implement gatewaySessionHandler.onDeviceDisconnect(mqttMsg); break; case MqttTopics.GATEWAY_METRICS_TOPIC: - gatewaySessionHandler.onGatewayLatency(mqttMsg); + gatewaySessionHandler.onGatewayMetrics(mqttMsg); break; default: ack(ctx, msgId, MqttReasonCodes.PubAck.TOPIC_NAME_INVALID); diff --git a/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/gateway/GatewayMetricsService.java b/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/gateway/GatewayMetricsService.java index 263888f4c2..c044c89e15 100644 --- a/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/gateway/GatewayMetricsService.java +++ b/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/gateway/GatewayMetricsService.java @@ -39,7 +39,7 @@ import java.util.concurrent.TimeUnit; @TbMqttTransportComponent public class GatewayMetricsService { - public static final String METRICS_CHECK = "metricsCheck"; + public static final String GATEWAY_METRICS = "gatewayMetrics"; @Value("${transport.mqtt.gateway_metrics_report_interval_sec:3600}") private int metricsReportIntervalSec; @@ -100,7 +100,7 @@ public class GatewayMetricsService { } var result = state.getStateResult(); var kvProto = TransportProtos.KeyValueProto.newBuilder() - .setKey(METRICS_CHECK) + .setKey(GATEWAY_METRICS) .setType(TransportProtos.KeyValueType.JSON_V) .setJsonV(JacksonUtil.toString(result)) .build(); diff --git a/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/session/GatewaySessionHandler.java b/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/session/GatewaySessionHandler.java index 32eaf6e0d7..9444787193 100644 --- a/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/session/GatewaySessionHandler.java +++ b/common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/session/GatewaySessionHandler.java @@ -84,7 +84,7 @@ public class GatewaySessionHandler extends AbstractGatewaySessionHandler