diff --git a/application/src/main/java/org/thingsboard/server/service/install/update/ImagesUpdater.java b/application/src/main/java/org/thingsboard/server/service/install/update/ImagesUpdater.java index 6f3210ba90..e711bf2682 100644 --- a/application/src/main/java/org/thingsboard/server/service/install/update/ImagesUpdater.java +++ b/application/src/main/java/org/thingsboard/server/service/install/update/ImagesUpdater.java @@ -73,13 +73,13 @@ public class ImagesUpdater { public void updateDeviceProfilesImages() { log.info("Updating device profiles images..."); - var deviceProfiles = new PageDataIterable<>(deviceProfileDao::findAll, 256); + var deviceProfiles = new PageDataIterable<>(deviceProfileDao::findAllWithImages, 256); updateImages(deviceProfiles, "device profile", imageService::replaceBase64WithImageUrl, deviceProfileDao); } public void updateAssetProfilesImages() { log.info("Updating asset profiles images..."); - var assetProfiles = new PageDataIterable<>(assetProfileDao::findAll, 256); + var assetProfiles = new PageDataIterable<>(assetProfileDao::findAllWithImages, 256); updateImages(assetProfiles, "asset profile", imageService::replaceBase64WithImageUrl, assetProfileDao); } diff --git a/dao/src/main/java/org/thingsboard/server/dao/asset/AssetProfileDao.java b/dao/src/main/java/org/thingsboard/server/dao/asset/AssetProfileDao.java index 14e023edcd..87e9177d66 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/asset/AssetProfileDao.java +++ b/dao/src/main/java/org/thingsboard/server/dao/asset/AssetProfileDao.java @@ -45,6 +45,6 @@ public interface AssetProfileDao extends Dao, ExportableEntityDao< AssetProfile findByName(TenantId tenantId, String profileName); - PageData findAll(PageLink pageLink); + PageData findAllWithImages(PageLink pageLink); } diff --git a/dao/src/main/java/org/thingsboard/server/dao/device/DeviceProfileDao.java b/dao/src/main/java/org/thingsboard/server/dao/device/DeviceProfileDao.java index c5ca8c054d..7bca5ebf8f 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/device/DeviceProfileDao.java +++ b/dao/src/main/java/org/thingsboard/server/dao/device/DeviceProfileDao.java @@ -47,6 +47,6 @@ public interface DeviceProfileDao extends Dao, ExportableEntityDa DeviceProfile findByName(TenantId tenantId, String profileName); - PageData findAll(PageLink pageLink); + PageData findAllWithImages(PageLink pageLink); } diff --git a/dao/src/main/java/org/thingsboard/server/dao/sql/asset/AssetProfileRepository.java b/dao/src/main/java/org/thingsboard/server/dao/sql/asset/AssetProfileRepository.java index 6c66363ed1..a9acef8608 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/sql/asset/AssetProfileRepository.java +++ b/dao/src/main/java/org/thingsboard/server/dao/sql/asset/AssetProfileRepository.java @@ -23,7 +23,6 @@ import org.springframework.data.repository.query.Param; import org.thingsboard.server.common.data.asset.AssetProfileInfo; import org.thingsboard.server.dao.ExportableEntityRepository; import org.thingsboard.server.dao.model.sql.AssetProfileEntity; -import org.thingsboard.server.dao.model.sql.WidgetsBundleEntity; import java.util.List; import java.util.UUID; @@ -70,4 +69,6 @@ public interface AssetProfileRepository extends JpaRepository findByImageLink(@Param("imageLink") String imageLink, Pageable page); + Page findAllByImageNotNull(Pageable pageable); + } diff --git a/dao/src/main/java/org/thingsboard/server/dao/sql/asset/JpaAssetProfileDao.java b/dao/src/main/java/org/thingsboard/server/dao/sql/asset/JpaAssetProfileDao.java index 98bdca1cc9..b57e5c0c40 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/sql/asset/JpaAssetProfileDao.java +++ b/dao/src/main/java/org/thingsboard/server/dao/sql/asset/JpaAssetProfileDao.java @@ -99,8 +99,8 @@ public class JpaAssetProfileDao extends JpaAbstractDao findAll(PageLink pageLink) { - return DaoUtil.toPageData(assetProfileRepository.findAll(DaoUtil.toPageable(pageLink))); + public PageData findAllWithImages(PageLink pageLink) { + return DaoUtil.toPageData(assetProfileRepository.findAllByImageNotNull(DaoUtil.toPageable(pageLink))); } @Override diff --git a/dao/src/main/java/org/thingsboard/server/dao/sql/device/DeviceProfileRepository.java b/dao/src/main/java/org/thingsboard/server/dao/sql/device/DeviceProfileRepository.java index 996e29f81f..a9baf60e60 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/sql/device/DeviceProfileRepository.java +++ b/dao/src/main/java/org/thingsboard/server/dao/sql/device/DeviceProfileRepository.java @@ -81,4 +81,6 @@ public interface DeviceProfileRepository extends JpaRepository findAllByImageNotNull(Pageable pageable); + } diff --git a/dao/src/main/java/org/thingsboard/server/dao/sql/device/JpaDeviceProfileDao.java b/dao/src/main/java/org/thingsboard/server/dao/sql/device/JpaDeviceProfileDao.java index 33d41b892c..12a91e3cf7 100644 --- a/dao/src/main/java/org/thingsboard/server/dao/sql/device/JpaDeviceProfileDao.java +++ b/dao/src/main/java/org/thingsboard/server/dao/sql/device/JpaDeviceProfileDao.java @@ -117,8 +117,8 @@ public class JpaDeviceProfileDao extends JpaAbstractDao findAll(PageLink pageLink) { - return DaoUtil.toPageData(deviceProfileRepository.findAll(DaoUtil.toPageable(pageLink))); + public PageData findAllWithImages(PageLink pageLink) { + return DaoUtil.toPageData(deviceProfileRepository.findAllByImageNotNull(DaoUtil.toPageable(pageLink))); } @Override