From f1fa6e6a011baee2e9e1325b39ee2f9d1fc4a31e Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Tue, 31 Oct 2023 15:36:57 +0100 Subject: [PATCH] DeviceCredentialsCacheTest total DB calls reduced from 2 to 3 due to nulls cached at findDeviceCredentialsByCredentialsId --- .../server/dao/service/DeviceCredentialsCacheTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dao/src/test/java/org/thingsboard/server/dao/service/DeviceCredentialsCacheTest.java b/dao/src/test/java/org/thingsboard/server/dao/service/DeviceCredentialsCacheTest.java index 44119af87a..000ab3728b 100644 --- a/dao/src/test/java/org/thingsboard/server/dao/service/DeviceCredentialsCacheTest.java +++ b/dao/src/test/java/org/thingsboard/server/dao/service/DeviceCredentialsCacheTest.java @@ -127,10 +127,10 @@ public class DeviceCredentialsCacheTest extends AbstractServiceTest { when(deviceCredentialsDao.findByCredentialsId(SYSTEM_TENANT_ID, CREDENTIALS_ID_1)).thenReturn(null); - deviceCredentialsService.findDeviceCredentialsByCredentialsId(CREDENTIALS_ID_1); - deviceCredentialsService.findDeviceCredentialsByCredentialsId(CREDENTIALS_ID_1); + deviceCredentialsService.findDeviceCredentialsByCredentialsId(CREDENTIALS_ID_1); // cache miss, DB read (not found), Cache put null value + deviceCredentialsService.findDeviceCredentialsByCredentialsId(CREDENTIALS_ID_1); // cache hit (null value, credentials not found) - verify(deviceCredentialsDao, times(3)).findByCredentialsId(SYSTEM_TENANT_ID, CREDENTIALS_ID_1); + verify(deviceCredentialsDao, times(2)).findByCredentialsId(SYSTEM_TENANT_ID, CREDENTIALS_ID_1); } private DeviceCredentialsService unwrapDeviceCredentialsService() throws Exception {