From e971fe8578124363afa425df992a533520051829 Mon Sep 17 00:00:00 2001
From: mpetrov <mpetrov@thingsboard.io>
Date: Wed, 7 Aug 2024 18:44:42 +0300
Subject: [PATCH] OPC-UA Connector Server tab minor UI adjustments

---
 .../opc-server-config/opc-server-config.component.html | 10 +++++-----
 .../opc-server-config/opc-server-config.component.ts   |  4 ++--
 ui-ngx/src/assets/locale/locale.constant-en_US.json    |  8 ++++----
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/opc-server-config/opc-server-config.component.html b/ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/opc-server-config/opc-server-config.component.html
index 4c992c0e21..8c3f3aaf4b 100644
--- a/ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/opc-server-config/opc-server-config.component.html
+++ b/ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/opc-server-config/opc-server-config.component.html
@@ -34,12 +34,12 @@
     </div>
   </div>
   <div class="tb-form-row column-xs" fxLayoutAlign="space-between center">
-    <div class="fixed-title-width" tb-hint-tooltip-icon="{{ 'gateway.hints.opcua-timeout' | translate }}">
+    <div class="fixed-title-width" tb-hint-tooltip-icon="{{ 'gateway.hints.opc-timeout' | translate }}">
       <div tbTruncateWithTooltip>{{ 'gateway.timeout' | translate }}</div>
     </div>
     <div class="tb-flex no-gap">
       <mat-form-field class="tb-flex no-gap" appearance="outline" subscriptSizing="dynamic">
-        <input matInput type="number" min="0" name="value" formControlName="timeoutInMillis" placeholder="{{ 'gateway.set' | translate }}"/>
+        <input matInput type="number" min="1000" name="value" formControlName="timeoutInMillis" placeholder="{{ 'gateway.set' | translate }}"/>
         <mat-icon matSuffix
                   matTooltipPosition="above"
                   matTooltipClass="tb-error-tooltip"
@@ -69,7 +69,7 @@
     </div>
     <div class="tb-flex no-gap">
       <mat-form-field class="tb-flex no-gap" appearance="outline" subscriptSizing="dynamic">
-        <input matInput type="number" min="0" name="value"
+        <input matInput type="number" min="1000" name="value"
                formControlName="scanPeriodInMillis" placeholder="{{ 'gateway.set' | translate }}"/>
         <mat-icon matSuffix
                   matTooltipPosition="above"
@@ -90,12 +90,12 @@
     </div>
     <div class="tb-flex no-gap">
       <mat-form-field class="tb-flex no-gap" appearance="outline" subscriptSizing="dynamic">
-        <input matInput type="number" min="0" name="value"
+        <input matInput type="number" min="100" name="value"
                formControlName="subCheckPeriodInMillis" placeholder="{{ 'gateway.set' | translate }}"/>
         <mat-icon matSuffix
                   matTooltipPosition="above"
                   matTooltipClass="tb-error-tooltip"
-                  [matTooltip]="'gateway.sub-check-period-error' | translate: {min: 10}"
+                  [matTooltip]="'gateway.sub-check-period-error' | translate: {min: 100}"
                   *ngIf="(serverConfigFormGroup.get('subCheckPeriodInMillis').hasError('required') ||
                          serverConfigFormGroup.get('subCheckPeriodInMillis').hasError('min')) &&
                          serverConfigFormGroup.get('subCheckPeriodInMillis').touched"
diff --git a/ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/opc-server-config/opc-server-config.component.ts b/ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/opc-server-config/opc-server-config.component.ts
index eddad255a3..6979bea076 100644
--- a/ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/opc-server-config/opc-server-config.component.ts
+++ b/ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/opc-server-config/opc-server-config.component.ts
@@ -82,7 +82,7 @@ export class OpcServerConfigComponent implements ControlValueAccessor, Validator
       timeoutInMillis: [1000, [Validators.required, Validators.min(1000)]],
       scanPeriodInMillis: [1000, [Validators.required, Validators.min(1000)]],
       enableSubscriptions: [true, []],
-      subCheckPeriodInMillis: [10, [Validators.required, Validators.min(10)]],
+      subCheckPeriodInMillis: [100, [Validators.required, Validators.min(100)]],
       showMap: [false, []],
       security: [SecurityPolicy.BASIC128, []],
       identity: [{}, [Validators.required]]
@@ -122,7 +122,7 @@ export class OpcServerConfigComponent implements ControlValueAccessor, Validator
       timeoutInMillis: timeoutInMillis || 1000,
       scanPeriodInMillis: scanPeriodInMillis || 1000,
       enableSubscriptions: enableSubscriptions || true,
-      subCheckPeriodInMillis: subCheckPeriodInMillis || 10,
+      subCheckPeriodInMillis: subCheckPeriodInMillis || 100,
       showMap: showMap || false,
       security: security || SecurityPolicy.BASIC128,
     };
diff --git a/ui-ngx/src/assets/locale/locale.constant-en_US.json b/ui-ngx/src/assets/locale/locale.constant-en_US.json
index 14eb272910..3c90b3bdd6 100644
--- a/ui-ngx/src/assets/locale/locale.constant-en_US.json
+++ b/ui-ngx/src/assets/locale/locale.constant-en_US.json
@@ -3166,9 +3166,9 @@
         "other": "Other",
         "save-tip": "Save configuration file",
         "scan-period": "Scan period (ms)",
-        "scan-period-error": "Scan period should be at least {{min}}(ms).",
+        "scan-period-error": "Scan period should be at least {{min}} (ms).",
         "sub-check-period": "Subscription check period (ms)",
-        "sub-check-period-error": "Subscription check period should be at least {{min}}(ms).",
+        "sub-check-period-error": "Subscription check period should be at least {{min}} (ms).",
         "security": "Security",
         "security-type": "Security type",
         "security-types": {
@@ -3280,7 +3280,7 @@
         "tidy": "Tidy",
         "tidy-tip": "Tidy config JSON",
         "timeout": "Timeout (ms)",
-        "timeout-error": "Timeout should be at least {{min}}(ms).",
+        "timeout-error": "Timeout should be at least {{min}} (ms).",
         "title-connectors-json": "Connector {{typeName}} configuration",
         "type": "Type",
         "topic-filter": "Topic filter",
@@ -3370,7 +3370,7 @@
             "framer-type": "Type of framer.",
             "file": "Your data will be stored in separated files and will be saved even after the gateway restart.",
             "sqlite": "Your data will be stored in file based database. And will be saved even after the gateway restart.",
-            "opcua-timeout": "Timeout in seconds for connecting to OPC-UA server.",
+            "opc-timeout": "Timeout in milliseconds for connecting to OPC-UA server.",
             "scan-period": "Period in milliseconds to rescan the server.",
             "sub-check-period": "Period to check the subscriptions in the OPC-UA server.",
             "enable-subscription": "If true - the gateway will subscribe to interesting nodes and wait for data update and if false - the gateway will rescan OPC-UA server every scanPeriodInMillis.",